Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Perspective toggle_config #6721

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Remove Perspective toggle_config #6721

merged 4 commits into from
Apr 17, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Apr 13, 2024

Closes #6720

@MarcSkovMadsen MarcSkovMadsen added this to the v1.4.2 milestone Apr 13, 2024
this.perspective_element.toggleConfig()
}

const themesArray = Object.values(THEMES);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perspective uses the first theme in the array as the default theme. If we don't put the model.theme first in the list we will see a glitch when it later changes to the model.theme.

@philippjfr philippjfr merged commit 5ee2d0f into main Apr 17, 2024
1 check passed
@philippjfr philippjfr deleted the fix/perspective branch April 17, 2024 16:38
@philippjfr
Copy link
Member

Damn, shouldn't have merged, this breaks Perspective. pre-commit shouldn't bypass the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perspective toggle_config not working
2 participants